Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 30 Sep 2021 09:22:09 -0700 | Subject | Re: [PATCH v2 1/3] arm64: dts: sc7180: Factor out ti-sn65dsi86 support |
| |
Hi,
On Wed, Sep 29, 2021 at 5:35 PM Philip Chen <philipchen@chromium.org> wrote: > > Factor out ti-sn65dsi86 edp bridge as a separate dts fragment. > This helps us introduce the second source edp bridge later. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Philip Chen <philipchen@chromium.org> > --- > > Changes in v2: > - Move edp_brij_i2c completely out of sc7180-trogdor.dtsi to the > bridge dts fragment, so that we can cleanly assign different > edp bridge in every board rev. > > .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 + > .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 1 + > .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 1 + > .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 1 + > .../dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 90 +++++++++++++++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 86 ------------------ > 6 files changed, 94 insertions(+), 86 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > index a758e4d22612..1d13fba3bd2f 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > @@ -11,6 +11,7 @@ > ap_h1_spi: &spi0 {}; > > #include "sc7180-trogdor.dtsi" > +#include "sc7180-trogdor-ti-sn65dsi86.dtsi"
It looks like you're missing homestar, aren't you? I'd expect that after applying your change that:
git grep -A1 include.*sc7180-trogdor.dtsi
...should show your new include right after all includes of sc7180-trogdor.dtsi, but I don't see it for homestar.
Other than that this looks good to me. Feel free to add my Reviewed-by.
| |