lkml.org 
[lkml]   [2021]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v17 10/15] arm64: kexec: use ld script for relocation function
Sorry, missed two comments:

> > /* Flush the reloc_code in preparation for its execution. */
> > dcache_clean_inval_poc((unsigned long)reloc_code,
> > - (unsigned long)reloc_code +
> > - arm64_relocate_new_kernel_size);
> > + (unsigned long)reloc_code + reloc_size);
>
> Extra whitespace.

Yeap, extra whitespace after '+', will fix it :)

>
> > icache_inval_pou((uintptr_t)reloc_code,
> > - (uintptr_t)reloc_code +
> > - arm64_relocate_new_kernel_size);
> > + (uintptr_t)reloc_code + reloc_size);
> > kexec_list_flush(kimage);
> > kexec_image_info(kimage);
> >
> > diff --git a/arch/arm64/kernel/relocate_kernel.S b/arch/arm64/kernel/relocate_kernel.S
> > index b4fb97312a80..9d2400855ee4 100644
> > --- a/arch/arm64/kernel/relocate_kernel.S
> > +++ b/arch/arm64/kernel/relocate_kernel.S
> > @@ -15,6 +15,7 @@
> > #include <asm/sysreg.h>
> > #include <asm/virt.h>
> >
> > +.pushsection ".kexec_relocate.text", "ax"
>
> Just use .section if you're putting the entire file in there?

Good point, I will change it to .section.

\
 
 \ /
  Last update: 2021-09-30 06:09    [W:0.179 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site