Messages in this thread | | | Date | Thu, 30 Sep 2021 12:25:45 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: rtl8712: Statements should start on a tabstop |
| |
On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote: > This path fixes four checkpatch.pl warnings: > > Statements should start on a tabstop > > Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com> > --- > drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h > index 2e6afc7bb0a1..bc1287cc853e 100644 > --- a/drivers/staging/rtl8712/rtl871x_xmit.h > +++ b/drivers/staging/rtl8712/rtl871x_xmit.h > @@ -182,11 +182,11 @@ struct sta_xmit_priv { > }; > > struct hw_txqueue { > - /*volatile*/ sint head; > - /*volatile*/ sint tail; > - /*volatile*/ sint free_sz; /*in units of 64 bytes*/ > - /*volatile*/ sint free_cmdsz; > - /*volatile*/ sint txsz[8]; > + /*volatile*/ sint head; > + /*volatile*/ sint tail; > + /*volatile*/ sint free_sz; /*in units of 64 bytes*/ > + /*volatile*/ sint free_cmdsz; > + /*volatile*/ sint txsz[8];
These "volatile" comments are wrong and pointless. Just delete them instead.
regards, dan carpenter
| |