Messages in this thread | | | Date | Wed, 29 Sep 2021 06:19:09 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v6] net: openvswitch: IPv6: Add IPv6 extension header support |
| |
On Wed, 29 Sep 2021 08:19:05 +0200 Nicolas Dichtel wrote: > > /* Insert a kernel only KEY_ATTR */ > > #define OVS_KEY_ATTR_TUNNEL_INFO __OVS_KEY_ATTR_MAX > > #undef OVS_KEY_ATTR_MAX > > #define OVS_KEY_ATTR_MAX __OVS_KEY_ATTR_MAX > Following the other thread [1], this will break if a new app runs over an old > kernel.
Good point.
> Why not simply expose this attribute to userspace and throw an error if a > userspace app uses it?
Does it matter if it's exposed or not? Either way the parsing policy for attrs coming from user space should have a reject for the value. (I say that not having looked at the code, so maybe I shouldn't...)
| |