lkml.org 
[lkml]   [2021]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] acpi/processor_idle.c: Fix kernel pointer leak
On Wed, Sep 29, 2021 at 12:56 PM Guo Zhi <qtxuning1999@sjtu.edu.cn> wrote:
>
> Pointers should be printed with %p or %px rather than
> cast to 'long' and pinted with %ld.
> Change %ld to %p to print the secured pointer.

In this particular case, id->driver_data represents a proper integer,
not an address, although technically it is a pointer data type. It
shouldn't be printed with %p and the patch is incorrect.

>
> Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
> ---
> drivers/acpi/processor_idle.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index f37fba9e5ba0..a9f4ab072583 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -73,9 +73,9 @@ static int set_max_cstate(const struct dmi_system_id *id)
> if (max_cstate > ACPI_PROCESSOR_MAX_POWER)
> return 0;
>
> - pr_notice("%s detected - limiting to C%ld max_cstate."
> + pr_notice("%s detected - limiting to C%p max_cstate."
> " Override with \"processor.max_cstate=%d\"\n", id->ident,
> - (long)id->driver_data, ACPI_PROCESSOR_MAX_POWER + 1);
> + id->driver_data, ACPI_PROCESSOR_MAX_POWER + 1);
>
> max_cstate = (long)id->driver_data;
>
> --
> 2.33.0
>

\
 
 \ /
  Last update: 2021-09-29 14:09    [W:5.337 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site