Messages in this thread | | | Subject | Re: [PATCH 2/4] amdgpu_ucode: reduce number of pr_debug calls | From | Joe Perches <> | Date | Wed, 29 Sep 2021 19:08:51 -0700 |
| |
On Wed, 2021-09-29 at 19:44 -0600, Jim Cromie wrote: > There are blocks of DRM_DEBUG calls, consolidate their args into > single calls. With dynamic-debug in use, each callsite consumes 56 > bytes of callsite data, and this patch removes about 65 calls, so > it saves ~3.5kb. > > no functional changes.
No functional change, but an output logging content change.
> RFC: this creates multi-line log messages, does that break any syslog > conventions ?
It does change the output as each individual DRM_DEBUG is a call to __drm_dbg which is effectively:
printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV", __builtin_return_address(0), &vaf);
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c [] > @@ -30,17 +30,26 @@ > > > static void amdgpu_ucode_print_common_hdr(const struct common_firmware_header *hdr) > { > - DRM_DEBUG("size_bytes: %u\n", le32_to_cpu(hdr->size_bytes)); > - DRM_DEBUG("header_size_bytes: %u\n", le32_to_cpu(hdr->header_size_bytes)); [] > + DRM_DEBUG("size_bytes: %u\n" > + "header_size_bytes: %u\n"
etc...
| |