Messages in this thread | | | Date | Wed, 29 Sep 2021 16:36:21 -0700 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH] arm64: dts: qcom: pmk8350: Make RTC disabled by default; enable on sc7280-idp |
| |
On Wed, Sep 29, 2021 at 03:38:14PM -0700, Douglas Anderson wrote: > The RTC on the pmk8350 is not useful on all boards. Some boards may > not provide backup power to the PMIC but might have another RTC on the > board that does have backup power. In this case it's better to not use > the RTC on the PMIC. > > At the moment, the only boards that includes this PMIC are sc7280-idp > and sc7280-idp2. On sc7280-idp I'm not aware of any other RTCs, but > sc7280-idp2 has a Chrome OS EC on it and this is intended to provide > the RTC for the AP. > > Let's do what we normally do for hardware that's not used by all > boards and set it to a default status of "disabled" and then enable it > on the boards that need it. > > NOTE: for sc7280-idp it's _possible_ we might also want to add > `allow-set-time;`. That could be the subject of a future patch if it > is indeed true. > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
| |