Messages in this thread | | | Date | Tue, 28 Sep 2021 10:52:22 +0100 | From | Lee Jones <> | Subject | Re: [RESEND PATCH v2 1/4] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type |
| |
On Wed, 02 Jun 2021, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org> > > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Samsung PMIC drivers are used only on Devicetree boards. > > Additionally, the PMIC datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > Marek Szyprowski reports that together with DTS change (proper level in > DTS) it fixes RTC alarm failure that he observed from time to time on > TM2e board. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > > --- > > Rebased on https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/log/?h=for-mfd-next > > Changes since v1: > 1. Mention in commit msg that this fixes TM2e RTC alarm. > 2. Add Marek's tested-by. > --- > drivers/mfd/sec-irq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |