lkml.org 
[lkml]   [2021]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH rdma-next v1 06/11] RDMA/nldev: Add support to get status of all counters
From
Date
On 9/28/2021 1:30 AM, Jason Gunthorpe wrote:
> On Wed, Sep 15, 2021 at 02:07:25AM +0300, Leon Romanovsky wrote:
>> +static int stat_get_doit_default_counter(struct sk_buff *skb,
>> + struct nlmsghdr *nlh,
>> + struct netlink_ext_ack *extack,
>> + struct nlattr *tb[])
>> +{
>> + struct rdma_hw_stats *stats;
>> + struct ib_device *device;
>> + u32 index, port;
>> + int ret;
>> +
>> + if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_PORT_INDEX])
>> + return -EINVAL;
>> +
>> + index = nla_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]);
>> + device = ib_device_get_by_index(sock_net(skb->sk), index);
>> + if (!device)
>> + return -EINVAL;
>> +
>> + port = nla_get_u32(tb[RDMA_NLDEV_ATTR_PORT_INDEX]);
>> + if (!rdma_is_port_valid(device, port)) {
>> + ret = -EINVAL;
>> + goto end;
>> + }
>> +
>> + stats = ib_get_hw_stats_port(device, port);
>> + if (!stats) {
>> + ret = -EINVAL;
>> + goto end;
>> + }
>> +
>> + if (tb[RDMA_NLDEV_ATTR_STAT_HWCOUNTER_DYNAMIC])
>> + ret = stat_get_doit_stats_list(skb, nlh, extack, tb,
>> + device, port, stats);
>> + else
>> + ret = stat_get_doit_stats_values(skb, nlh, extack, tb, device,
>> + port, stats);
>
> This seems strange, why is the output of a get contingent on a ignored
> input attribute? Shouldn't the HWCOUNTER_DYNAMIC just always be
> emitted?

The CMD_STAT_GET is originally used to get the default hwcounter
statistic (the value of all hwstats), now we also want to use this
command to get a list of counters (just name and status), so kernel
differentiates these 2 cases based on HWCOUNTER_DYNAMIC attr.

\
 
 \ /
  Last update: 2021-09-28 11:13    [W:3.511 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site