lkml.org 
[lkml]   [2021]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 19/23] thermal/drivers/tsens: Fix wrong check for tzd in irq handlers
    Date
    From: Ansuel Smith <ansuelsmth@gmail.com>

    [ Upstream commit cf96921876dcee4d6ac07b9de470368a075ba9ad ]

    Some devices can have some thermal sensors disabled from the
    factory. The current two irq handler functions check all the sensor by
    default and the check if the sensor was actually registered is
    wrong. The tzd is actually never set if the registration fails hence
    the IS_ERR check is wrong.

    Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
    Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Link: https://lore.kernel.org/r/20210907212543.20220-1-ansuelsmth@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/thermal/qcom/tsens.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
    index 3c4c0516e58a..cb4f4b522446 100644
    --- a/drivers/thermal/qcom/tsens.c
    +++ b/drivers/thermal/qcom/tsens.c
    @@ -415,7 +415,7 @@ static irqreturn_t tsens_critical_irq_thread(int irq, void *data)
    const struct tsens_sensor *s = &priv->sensor[i];
    u32 hw_id = s->hw_id;

    - if (IS_ERR(s->tzd))
    + if (!s->tzd)
    continue;
    if (!tsens_threshold_violated(priv, hw_id, &d))
    continue;
    @@ -465,7 +465,7 @@ static irqreturn_t tsens_irq_thread(int irq, void *data)
    const struct tsens_sensor *s = &priv->sensor[i];
    u32 hw_id = s->hw_id;

    - if (IS_ERR(s->tzd))
    + if (!s->tzd)
    continue;
    if (!tsens_threshold_violated(priv, hw_id, &d))
    continue;
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-09-28 08:01    [W:5.107 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site