lkml.org 
[lkml]   [2021]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 009/162] usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 517c7bf99bad3d6b9360558414aae634b7472d80 upstream.

    This is writing to the first 1 - 3 bytes of "val" and then writing all
    four bytes to musb_writel(). The last byte is always going to be
    garbage. Zero out the last bytes instead.

    Fixes: 550a7375fe72 ("USB: Add MUSB and TUSB support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Cc: stable <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20210916135737.GI25094@kili
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/musb/tusb6010.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/musb/tusb6010.c
    +++ b/drivers/usb/musb/tusb6010.c
    @@ -190,6 +190,7 @@ tusb_fifo_write_unaligned(void __iomem *
    }
    if (len > 0) {
    /* Write the rest 1 - 3 bytes to FIFO */
    + val = 0;
    memcpy(&val, buf, len);
    musb_writel(fifo, 0, val);
    }

    \
     
     \ /
      Last update: 2021-09-27 19:20    [W:2.593 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site