lkml.org 
[lkml]   [2021]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 064/162] net: hns3: fix inconsistent vf id print
    Date
    From: Jian Shen <shenjian15@huawei.com>

    [ Upstream commit 91bc0d5272d3a4dc3d4fd2a74387c7e7361bbe96 ]

    The vf id from ethtool is added 1 before configured to driver.
    So it's necessary to minus 1 when printing it, in order to
    keep consistent with user's configuration.

    Fixes: dd74f815dd41 ("net: hns3: Add support for rule add/delete for flow director")
    Signed-off-by: Jian Shen <shenjian15@huawei.com>
    Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
    index 40c4949eed4d..45faf924bc36 100644
    --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
    @@ -6635,10 +6635,13 @@ static int hclge_fd_parse_ring_cookie(struct hclge_dev *hdev, u64 ring_cookie,
    u8 vf = ethtool_get_flow_spec_ring_vf(ring_cookie);
    u16 tqps;

    + /* To keep consistent with user's configuration, minus 1 when
    + * printing 'vf', because vf id from ethtool is added 1 for vf.
    + */
    if (vf > hdev->num_req_vfs) {
    dev_err(&hdev->pdev->dev,
    - "Error: vf id (%u) > max vf num (%u)\n",
    - vf, hdev->num_req_vfs);
    + "Error: vf id (%u) should be less than %u\n",
    + vf - 1, hdev->num_req_vfs);
    return -EINVAL;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-09-27 19:37    [W:5.319 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site