lkml.org 
[lkml]   [2021]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 096/162] fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
    Date
    From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

    [ Upstream commit a1e4470823d99e75b596748086e120dea169ed3c ]

    The error code is missing in this code scenario, add the error code
    '-EINVAL' to the return value 'ret'.

    Eliminate the follow smatch warning:

    drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
    warn: missing error code 'ret'.

    [mdf@kernel.org: Reworded commit message]
    Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
    Signed-off-by: Moritz Fischer <mdf@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/fpga/machxo2-spi.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c
    index b4a530a31302..ea2ec3c6815c 100644
    --- a/drivers/fpga/machxo2-spi.c
    +++ b/drivers/fpga/machxo2-spi.c
    @@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
    break;
    if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) {
    machxo2_cleanup(mgr);
    + ret = -EINVAL;
    goto fail;
    }
    } while (1);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-09-27 19:37    [W:2.255 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site