lkml.org 
[lkml]   [2021]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 6/6] USB: serial: kl5kusb105: use usb_control_msg_recv() and usb_control_msg_send()
On Tue, Sep 21, 2021 at 2:41 PM Johan Hovold <johan@kernel.org> wrote:
>
> On Mon, Aug 02, 2021 at 02:01:22AM +0530, Himadri Pandya wrote:
> > The wrappers usb_control_msg_send/recv eliminate the need of allocating
> > dma buffers for usb message. They also impose proper error checks on the
> > return value of usb_control_msg() to handle short read/write. Hence use
> > the wrappers and remove dma allocations.
> >
> > Signed-off-by: Himadri Pandya <himadrispandya@gmail.com>
> > ---
> > Changes in v2:
> > - Fix the caller of klsi_105_chg_port_settings()
> > - Drop unnecessary use of the wrappers
>
> Now applied with an amended commit message:
>
> USB: serial: kl5kusb105: use usb_control_msg_recv() and usb_control_msg_send()
>
> The wrappers usb_control_msg_send/recv eliminate the need of
> manually allocating DMA buffers for USB messages. They also treat
> short reads as an error. Hence use the wrappers and remove DMA
> allocations.
>
> Note that short reads are now logged as -EREMOTEIO instead of the amount
> of data read.
>
> I've applied all but the first two patches in the series now. Would you
> mind respinning those two?
>
> Thanks,
> Johan

Thanks for reviewing and applying these patches. And yes, I'm sending
the revised version for the first two.

Regards,
Himadri

\
 
 \ /
  Last update: 2021-09-26 15:00    [W:0.057 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site