lkml.org 
[lkml]   [2021]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI
On Sun, Sep 26, 2021 at 10:26:47AM +0800, Jason Wang wrote:
>
> 在 2021/9/22 下午8:46, Wu Zongyong 写道:
> > +
> > +#ifdef __LITTLE_ENDIAN
>
>
> I think disable the device via Kconfig is better than letting user to meet
> errors like this.
>
> (Or if the device is always using little endian, we don't even need to
> bother this).

I prefer the second suggestion since there are no use cases that the
device uses big endian
>
> Thanks
>
>
> > +static int eni_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> > +{
> > + struct device *dev = &pdev->dev;
> > + struct eni_vdpa *eni_vdpa;
> > + struct virtio_pci_legacy_device *ldev;
> > + int ret, i;
> > +
> > + ret = pcim_enable_device(pdev);
> > + if (ret)
> > + return ret;
> > +

\
 
 \ /
  Last update: 2021-09-26 05:27    [W:0.151 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site