Messages in this thread Patch in this message | | | Date | Fri, 24 Sep 2021 11:50:52 +0200 | Subject | Re: [PATCH -next] drm/gma500: Fix wrong pointer passed to PTR_ERR() | From | Thomas Zimmermann <> |
| |
Hi
Am 24.09.21 um 11:40 schrieb Yang Yingliang: > PTR_ERR() should access the value just tested by IS_ERR(), > otherwise the wrong error code will be returned. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Indeed, thanks for the patch.
I'll add the fix with the correct Fixes tag soon.
Best regards Thomas
> --- > drivers/gpu/drm/gma500/psb_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c > index 3d036d2a3b29..7a10bb39ef0b 100644 > --- a/drivers/gpu/drm/gma500/psb_drv.c > +++ b/drivers/gpu/drm/gma500/psb_drv.c > @@ -454,7 +454,7 @@ static int psb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > dev_priv = devm_drm_dev_alloc(&pdev->dev, &driver, struct drm_psb_private, dev); > if (IS_ERR(dev_priv)) > - return PTR_ERR(dev); > + return PTR_ERR(dev_priv); > dev = &dev_priv->dev; > > pci_set_drvdata(pdev, dev); >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [unhandled content-type:application/pgp-signature] | |