Messages in this thread | | | From | Asmaa Mnebhi <> | Subject | [PATCH v3 0/2] gpio: mlxbf2: Introduce proper interrupt handling | Date | Thu, 23 Sep 2021 16:18:02 -0400 |
| |
This is a follow up on a discussion regarding proper handling of GPIO interrupts within the gpio-mlxbf2.c driver.
Link to discussion: https://lore.kernel.org/netdev/20210816115953.72533-7-andriy.shevchenko@linux.intel.com/T/
Patch 1 adds support to a GPIO IRQ handler in gpio-mlxbf2.c. Patch 2 is a follow up removal of custom GPIO IRQ handling from the mlxbf_gige driver and replacing it with a simple IRQ request. The ACPI table for the mlxbf_gige driver is responsible for instantiating the PHY GPIO interrupt via GpioInt.
Andy Shevchenko, could you please review this patch series.
v3 vs. v2 patch: - Add IRQ_TYPE_LEVEL* back to mlxbf2_gpio_irq_set_type. YU_GPIO_CAUSE_FALL_EN and YU_GPIO_CAUSE_RISE_EN are configured in Both level and edge interrupts cases.
Asmaa Mnebhi (2): gpio: mlxbf2: Introduce IRQ support net: mellanox: mlxbf_gige: Replace non-standard interrupt handling
drivers/gpio/gpio-mlxbf2.c | 150 ++++++++++++- .../net/ethernet/mellanox/mlxbf_gige/Makefile | 1 - .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h | 12 - .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------ .../mellanox/mlxbf_gige/mlxbf_gige_main.c | 22 +- 5 files changed, 157 insertions(+), 240 deletions(-) delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c
-- 2.30.1
| |