lkml.org 
[lkml]   [2021]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] net: rtnetlink: convert rcu_assign_pointer to RCU_INIT_POINTER
From
Date


On 9/17/21 11:36 PM, Yajun Deng wrote:
> It no need barrier when assigning a NULL value to an RCU protected
> pointer. So use RCU_INIT_POINTER() instead for more fast.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> net/core/rtnetlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 972c8cb303a5..327ca6bc6e6d 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -301,7 +301,7 @@ int rtnl_unregister(int protocol, int msgtype)
> }
>
> link = rtnl_dereference(tab[msgindex]);
> - rcu_assign_pointer(tab[msgindex], NULL);
> + RCU_INIT_POINTER(tab[msgindex], NULL);
> rtnl_unlock();
>
> kfree_rcu(link, rcu);
> @@ -337,7 +337,7 @@ void rtnl_unregister_all(int protocol)
> if (!link)
> continue;
>
> - rcu_assign_pointer(tab[msgindex], NULL);
> + RCU_INIT_POINTER(tab[msgindex], NULL);
> kfree_rcu(link, rcu);
> }
> rtnl_unlock();
>

FYI, there is no memory barrier involved in

rcu_assign_pointer(tab[msgindex], NULL);

This has been the case for the last 5 years.

Your patch was not needed really.

\
 
 \ /
  Last update: 2021-09-23 19:10    [W:0.047 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site