lkml.org 
[lkml]   [2021]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v9 16/16] staging: r8188eu: remove usb_vendor_req_mutex
From
On 9/22/21 16:21, Pavel Skripkin wrote:
> On 9/21/21 21:18, Fabio M. De Francesco wrote:
>> From: Pavel Skripkin <paskripkin@gmail.com>
>>
>> This mutex was used to protect shared buffer for USB requests. Since
>> buffer was removed in previous patch we can remove this mutex as well.
>>
>> Furthermore, because it was used to serialize the calls to the Core USB
>> API, we thoroughly tested the enabling of concurrent firing of USB requests
>> without the mutex and found no problems of any kind in common use cases.
>>
>> Co-developed-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
>
> Hi, Greg!
>
> If all is OK with previous 15 patches, please, do not take this one, it
> causes problems with connection... :)
>
> I don't understand what went wrong after v8, but anyway, this one should
> not be applied for now, since it's broken
>
>
> Thank you
>
>


Just to be clear: previous 15 patches _are_ tested and do not cause any
misbehavior or bugs.

I guess, the stack buffer maybe the problem here, since it's the only
change on this side since v8. I didn't have a chance to take a closer
look, but I will do it on weekends, I hope :)



With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2021-09-23 10:48    [W:1.449 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site