Messages in this thread | | | Date | Thu, 23 Sep 2021 01:48:56 +0800 | From | Liu Bo <> | Subject | Re: [PATCH] erofs: fix misbehavior of unsupported chunk format check |
| |
On Wed, Sep 22, 2021 at 05:51:41PM +0800, Gao Xiang wrote: > Unsupported chunk format should be checked with > "if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL)" > > Found when checking with 4k-byte blockmap (although currently mkfs > uses inode chunk indexes format by default.) >
Good catch.
Reviewed-by: Liu Bo <bo.liu@linux.alibaba.com>
thanks, liubo
> Fixes: c5aa903a59db ("erofs: support reading chunk-based uncompressed files") > Cc: Liu Bo <bo.liu@linux.alibaba.com> > Cc: Chao Yu <chao@kernel.org> > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> > --- > fs/erofs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c > index 31ac3a7..a552399 100644 > --- a/fs/erofs/inode.c > +++ b/fs/erofs/inode.c > @@ -176,7 +176,7 @@ static struct page *erofs_read_inode(struct inode *inode, > } > > if (vi->datalayout == EROFS_INODE_CHUNK_BASED) { > - if (!(vi->chunkformat & EROFS_CHUNK_FORMAT_ALL)) { > + if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL) { > erofs_err(inode->i_sb, > "unsupported chunk format %x of nid %llu", > vi->chunkformat, vi->nid); > -- > 1.8.3.1
| |