Messages in this thread | | | Subject | Re: [PATCH v3 2/3] ASoC: Use schema reference for sound-name-prefix | From | Sameer Pujar <> | Date | Tue, 21 Sep 2021 20:45:10 +0530 |
| |
On 9/20/2021 6:27 PM, Rob Herring wrote: > External email: Use caution opening links or attachments > > > On Fri, Sep 3, 2021 at 11:36 AM Sameer Pujar <spujar@nvidia.com> wrote: >> Use schema reference for 'sound-name-prefix' property wherever >> necessary. >> >> Signed-off-by: Sameer Pujar <spujar@nvidia.com> >> Cc: Jerome Brunet <jbrunet@baylibre.com> >> Cc: Stephan Gerhold <stephan@gerhold.net> >> Cc: Rob Herring <robh+dt@kernel.org> >> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- > [...] > >> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml >> index ffb8fcf..68e5ad2 100644 >> --- a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml >> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml >> @@ -9,6 +9,9 @@ title: NXP/Goodix TFA989X (TFA1) Audio Amplifiers >> maintainers: >> - Stephan Gerhold <stephan@gerhold.net> >> >> +allOf: >> + - $ref: name-prefix.yaml# >> + >> properties: >> compatible: >> enum: >> @@ -21,12 +24,6 @@ properties: >> '#sound-dai-cells': >> const: 0 >> >> - sound-name-prefix: > You can't remove the property. This is now a warning in linux-next: > > Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml: > audio-codec@34: 'sound-name-prefix' does not match any of the regexes: > 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml > Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml: > audio-codec@36: 'sound-name-prefix' does not match any of the regexes: > 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml > > > Just 'sound-name-prefix: true' is fine
I will push a fix for this.
| |