lkml.org 
[lkml]   [2021]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next v2] arm64: PCI: Introduce pcibios_free_irq() helper function
On Thu, Aug 26, 2021 at 02:04:06PM +0800, Yajun Deng wrote:
> pcibios_alloc_irq() will be called in pci_device_probe(), but there
> hasn't pcibios_free_irq() in arm64 architecture correspond it.
> pcibios_free_irq() is an empty weak function in drivers/pci/pci-driver.c.
> So add pcibios_free_irq() for correspond it. This will be called
> in pci_device_remove().
>
> ====================
> v2: remove the change in pcibios_alloc_irq(), and modify the commit log.
> ====================
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> arch/arm64/kernel/pci.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
> index 2276689b5411..6ffd92126f65 100644
> --- a/arch/arm64/kernel/pci.c
> +++ b/arch/arm64/kernel/pci.c
> @@ -29,6 +29,13 @@ int pcibios_alloc_irq(struct pci_dev *dev)
>
> return 0;
> }
> +
> +void pcibios_free_irq(struct pci_dev *dev)
> +{
> + if (!acpi_disabled)
> + acpi_pci_irq_disable(dev);
> +}

For symmetry with the alloc path, this looks fine but I'd like Lorenzo
to confirm.

The other questions, what does it fix and do we need a cc stable?

Thanks.

--
Catalin

\
 
 \ /
  Last update: 2021-09-21 15:49    [W:0.444 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site