lkml.org 
[lkml]   [2021]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] irqchip/renesas-rza1: Use semicolons instead of commas

> On 09/15/2021 11:47 AM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
>
> This code works, but it is cleaner to use semicolons at the end of
> statements instead of commas.
>
> Extracted from a big anonymous patch by Julia Lawall
> <julia.lawall@inria.fr>.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/irqchip/irq-renesas-rza1.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/irqchip/irq-renesas-rza1.c b/drivers/irqchip/irq-renesas-rza1.c
> index b0d46ac42b892340..72c06e883d1c5fd5 100644
> --- a/drivers/irqchip/irq-renesas-rza1.c
> +++ b/drivers/irqchip/irq-renesas-rza1.c
> @@ -223,12 +223,12 @@ static int rza1_irqc_probe(struct platform_device *pdev)
> goto out_put_node;
> }
>
> - priv->chip.name = "rza1-irqc",
> - priv->chip.irq_mask = irq_chip_mask_parent,
> - priv->chip.irq_unmask = irq_chip_unmask_parent,
> - priv->chip.irq_eoi = rza1_irqc_eoi,
> - priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy,
> - priv->chip.irq_set_type = rza1_irqc_set_type,
> + priv->chip.name = "rza1-irqc";
> + priv->chip.irq_mask = irq_chip_mask_parent;
> + priv->chip.irq_unmask = irq_chip_unmask_parent;
> + priv->chip.irq_eoi = rza1_irqc_eoi;
> + priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy;
> + priv->chip.irq_set_type = rza1_irqc_set_type;
> priv->chip.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_WAKE;
>
> priv->irq_domain = irq_domain_add_hierarchy(parent, 0, IRQC_NUM_IRQ,
> --
> 2.25.1

Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>

CU
Uli

\
 
 \ /
  Last update: 2021-09-21 12:56    [W:0.052 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site