lkml.org 
[lkml]   [2021]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl
From
On 21. 09. 21, 6:00, Dmitry Torokhov wrote:
> Hi Jiri,
>
> On Tue, Sep 14, 2021 at 11:11:25AM +0200, Jiri Slaby wrote:
>> diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c
>> index 17eb8f2aa48d..55e91d0e70ec 100644
>> --- a/drivers/input/serio/serport.c
>> +++ b/drivers/input/serio/serport.c
>> @@ -207,8 +207,8 @@ static void serport_set_type(struct tty_struct *tty, unsigned long type)
>> * serport_ldisc_ioctl() allows to set the port protocol, and device ID
>> */
>>
>> -static int serport_ldisc_ioctl(struct tty_struct *tty, struct file *file,
>> - unsigned int cmd, unsigned long arg)
>> +static int serport_ldisc_ioctl(struct tty_struct *tty, unsigned int cmd,
>> + unsigned long arg)
>
> Can we please keep arguments aligned as they were? Otherwise

Fixed, thanks. Likely, I will send a follow-up -- depending if Greg
drops or keeps these in the tree.

--
js
suse labs

\
 
 \ /
  Last update: 2021-09-21 12:53    [W:0.145 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site