lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 051/133] usb: phy: fsl-usb: add IRQ check
    Date
    From: Sergey Shtylyov <s.shtylyov@omp.ru>

    [ Upstream commit ecc2f30dbb25969908115c81ec23650ed982b004 ]

    The driver neglects to check the result of platform_get_irq()'s call and
    blithely passes the negative error codes to request_irq() (which takes
    *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
    error code. Stop calling request_irq() with the invalid IRQ #s.

    Fixes: 0807c500a1a6 ("USB: add Freescale USB OTG Transceiver driver")
    Acked-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
    Link: https://lore.kernel.org/r/b0a86089-8b8b-122e-fd6d-73e8c2304964@omp.ru
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/phy/phy-fsl-usb.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c
    index 85d031ce85c1..63798de8b5ae 100644
    --- a/drivers/usb/phy/phy-fsl-usb.c
    +++ b/drivers/usb/phy/phy-fsl-usb.c
    @@ -891,6 +891,8 @@ int usb_otg_start(struct platform_device *pdev)

    /* request irq */
    p_otg->irq = platform_get_irq(pdev, 0);
    + if (p_otg->irq < 0)
    + return p_otg->irq;
    status = request_irq(p_otg->irq, fsl_otg_isr,
    IRQF_SHARED, driver_name, p_otg);
    if (status) {
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-20 18:50    [W:4.261 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site