lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 007/133] ALSA: pcm: fix divide error in snd_pcm_lib_ioctl
    Date
    From: Zubin Mithra <zsm@chromium.org>

    commit f3eef46f0518a2b32ca1244015820c35a22cfe4a upstream.

    Syzkaller reported a divide error in snd_pcm_lib_ioctl. fifo_size
    is of type snd_pcm_uframes_t(unsigned long). If frame_size
    is 0x100000000, the error occurs.

    Fixes: a9960e6a293e ("ALSA: pcm: fix fifo_size frame calculation")
    Signed-off-by: Zubin Mithra <zsm@chromium.org>
    Reviewed-by: Guenter Roeck <groeck@chromium.org>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20210827153735.789452-1-zsm@chromium.org
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/core/pcm_lib.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/core/pcm_lib.c
    +++ b/sound/core/pcm_lib.c
    @@ -1830,7 +1830,7 @@ static int snd_pcm_lib_ioctl_fifo_size(s
    channels = params_channels(params);
    frame_size = snd_pcm_format_size(format, channels);
    if (frame_size > 0)
    - params->fifo_size /= (unsigned)frame_size;
    + params->fifo_size /= frame_size;
    }
    return 0;
    }

    \
     
     \ /
      Last update: 2021-09-20 18:46    [W:2.862 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site