lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] [RFC] blk-iocost stringop-overread warning workaround
On Mon, Sep 20, 2021 at 3:15 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> In some randconfig builds with gcc-11, I get a warning from
> the fortified string helpers:
>
> In function 'memcpy',
> inlined from 'ioc_cost_model_write' at block/blk-iocost.c:3345:2:
> include/linux/fortify-string.h:20:33: error: '__builtin_memcpy' reading 48 bytes from a region of size 0 [-Werror=stringop-overread]
> 20 | #define __underlying_memcpy __builtin_memcpy
> | ^
> include/linux/fortify-string.h:191:16: note: in expansion of macro '__underlying_memcpy'
> 191 | return __underlying_memcpy(p, q, size);
> | ^~~~~~~~~~~~~~~~~~~
>
> I don't see anything wrong in the code itself, so I suspect it's
> gcc doing something weird again. The only way I could find to make
> this warning go away is to hide the object using the RELOC_HIDE()
> macro, but this is really ugly and I hope someone has a better
> idea.
>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Please disregard my patch for now. After looking closer, I found that I had
applied a patch that accidentally removed the

KBUILD_CFLAGS += -fno-delete-null-pointer-checks

line from the top-level Makefile. If I put that line back, the warning
disappears.

Arnd

\
 
 \ /
  Last update: 2021-09-20 18:19    [W:0.054 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site