| Date | Mon, 20 Sep 2021 13:46:24 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v8 01/19] staging: r8188eu: clean up symbols usbctrl_vendorreq() |
| |
On Mon, Sep 20, 2021 at 01:53:38AM +0200, Fabio M. De Francesco wrote: > Clean up symbol names in usbctrl_vendorreq(): > > pdata => data; > pio_priv => io_priv; > pintfhdl => intfhdl.
Odd mix of tabs and spaces :(
Anyway, what does intfhdl mean?
Ugh, that's a horrible structure name for a driver, but that's not your fault. However, isn't 'intf' a better name for this thing as that is how the driver does use it in other structures?
This isn't windows, where "handles" are used all over the places. We have real structures :)
thanks,
greg k-h
|