Messages in this thread | | | Date | Mon, 20 Sep 2021 12:06:32 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH 2/2] firmware: arm_scmi: remove __exit annotation |
| |
On Mon, Sep 20, 2021 at 12:02:52PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > virtio_scmi_exit() is only called from __exit function, so the annotation > is correct, but when the driver is built-in, the section gets discarded > and the reference from a callback pointer causes a link-time error: > > `virtio_scmi_exit' referenced in section `.rodata' of drivers/firmware/arm_scmi/virtio.o: defined in discarded section `.exit.text' of drivers/firmware/arm_scmi/virtio.o > > I could not figure out a better workaround, so let's just remove that > annotation even if it wastes a couple of bytes in .text. >
[...]
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[2/2] firmware: arm_scmi: remove __exit annotation https://git.kernel.org/sudeep.holla/c/1cd73200da
-- Regards, Sudeep
| |