lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] misc: fastrpc: fix improper packet size calculation
On 2021-09-20 14:38, Greg KH wrote:
> On Mon, Sep 20, 2021 at 01:45:31PM +0530, Jeya R wrote:
>> The buffer list is sorted and this is not being
>> considered while calculating packet size. This
>> would lead to improper copy length calculation
>> for non-dmaheap buffers which would eventually
>> cause sending improper buffers to DSP.
>
> You do have the full 72 columns to use :)

Thanks, will update the commit message considering this.

>
>>
>> Signed-off-by: Jeya R <jeyr@codeaurora.org>
>> ---
>> drivers/misc/fastrpc.c | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> What commit does this fix?
>
> thanks,
>
> greg k-h

Payload calculation function was modified to handle buffer overlapping
calculation in this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/misc/fastrpc.c?h=v5.15-rc2&id=25e8dfb83cda0a123bb1e091d6c3599cde050d76

Here during buffer overlap calculation, the buffer list is getting
sorted. This needs to be considered during the calculation of payload
size also by using unsorted buffer index "raix".

\
 
 \ /
  Last update: 2021-09-20 11:31    [W:1.696 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site