lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 037/293] crypto: omap-sham - clear dma flags only after omap_sham_update_dma_stop()
    Date
    From: Tony Lindgren <tony@atomide.com>

    [ Upstream commit fe28140b3393b0ba1eb95cc109f974a7e58b26fd ]

    We should not clear FLAGS_DMA_ACTIVE before omap_sham_update_dma_stop() is
    done calling dma_unmap_sg(). We already clear FLAGS_DMA_ACTIVE at the
    end of omap_sham_update_dma_stop().

    The early clearing of FLAGS_DMA_ACTIVE is not causing issues as we do not
    need to defer anything based on FLAGS_DMA_ACTIVE currently. So this can be
    applied as clean-up.

    Cc: Lokesh Vutla <lokeshvutla@ti.com>
    Cc: Tero Kristo <kristo@kernel.org>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/omap-sham.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
    index 4d31ef472436..180f2f61b8fb 100644
    --- a/drivers/crypto/omap-sham.c
    +++ b/drivers/crypto/omap-sham.c
    @@ -1739,7 +1739,7 @@ static void omap_sham_done_task(unsigned long data)
    if (test_and_clear_bit(FLAGS_OUTPUT_READY, &dd->flags))
    goto finish;
    } else if (test_bit(FLAGS_DMA_READY, &dd->flags)) {
    - if (test_and_clear_bit(FLAGS_DMA_ACTIVE, &dd->flags)) {
    + if (test_bit(FLAGS_DMA_ACTIVE, &dd->flags)) {
    omap_sham_update_dma_stop(dd);
    if (dd->err) {
    err = dd->err;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-20 20:07    [W:5.276 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site