lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 067/293] Bluetooth: sco: prevent information leak in sco_conn_defer_accept()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 59da0b38bc2ea570ede23a3332ecb3e7574ce6b2 ]

    Smatch complains that some of these struct members are not initialized
    leading to a stack information disclosure:

    net/bluetooth/sco.c:778 sco_conn_defer_accept() warn:
    check that 'cp.retrans_effort' doesn't leak information

    This seems like a valid warning. I've added a default case to fix
    this issue.

    Fixes: 2f69a82acf6f ("Bluetooth: Use voice setting in deferred SCO connection request")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/bluetooth/sco.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
    index a4ca55df7390..2561e462400e 100644
    --- a/net/bluetooth/sco.c
    +++ b/net/bluetooth/sco.c
    @@ -761,6 +761,11 @@ static void sco_conn_defer_accept(struct hci_conn *conn, u16 setting)
    cp.max_latency = cpu_to_le16(0xffff);
    cp.retrans_effort = 0xff;
    break;
    + default:
    + /* use CVSD settings as fallback */
    + cp.max_latency = cpu_to_le16(0xffff);
    + cp.retrans_effort = 0xff;
    + break;
    }

    hci_send_cmd(hdev, HCI_OP_ACCEPT_SYNC_CONN_REQ,
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-20 19:43    [W:2.428 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site