lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 022/217] powerpc/boot: Delete unneeded .globl _zimage_start
    Date
    From: Fangrui Song <maskray@google.com>

    commit 968339fad422a58312f67718691b717dac45c399 upstream.

    .globl sets the symbol binding to STB_GLOBAL while .weak sets the
    binding to STB_WEAK. GNU as let .weak override .globl since
    binutils-gdb 5ca547dc2399a0a5d9f20626d4bf5547c3ccfddd (1996). Clang
    integrated assembler let the last win but it may error in the future.

    Since it is a convention that only one binding directive is used, just
    delete .globl.

    Fixes: ee9d21b3b358 ("powerpc/boot: Ensure _zimage_start is a weak symbol")
    Signed-off-by: Fangrui Song <maskray@google.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20200325164257.170229-1-maskray@google.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/powerpc/boot/crt0.S | 3 ---
    1 file changed, 3 deletions(-)

    --- a/arch/powerpc/boot/crt0.S
    +++ b/arch/powerpc/boot/crt0.S
    @@ -49,9 +49,6 @@ p_end: .long _end
    p_pstack: .long _platform_stack_top
    #endif

    - .globl _zimage_start
    - /* Clang appears to require the .weak directive to be after the symbol
    - * is defined. See https://bugs.llvm.org/show_bug.cgi?id=38921 */
    .weak _zimage_start
    _zimage_start:
    .globl _zimage_start_lib

    \
     
     \ /
      Last update: 2021-09-20 19:37    [W:4.812 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site