Messages in this thread Patch in this message | | | From | Sireesh Kodali <> | Subject | [RFC PATCH 06/17] net: ipa: Add timeout for ipa_cmd_pipeline_clear_wait | Date | Mon, 20 Sep 2021 08:38:00 +0530 |
| |
From: Vladimir Lypak <vladimir.lypak@gmail.com>
Sometimes the pipeline clear fails, and when it does, having a hang in kernel is ugly. The timeout gives us a nice error message. Note that this shouldn't actually hang, ever. It only hangs if there is a mistake in the config, and the timeout is only useful when debugging.
Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com> Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> --- drivers/net/ipa/ipa_cmd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_cmd.c b/drivers/net/ipa/ipa_cmd.c index 3db9e94e484f..0bdbc331fa78 100644 --- a/drivers/net/ipa/ipa_cmd.c +++ b/drivers/net/ipa/ipa_cmd.c @@ -658,7 +658,10 @@ u32 ipa_cmd_pipeline_clear_count(void) void ipa_cmd_pipeline_clear_wait(struct ipa *ipa) { - wait_for_completion(&ipa->completion); + unsigned long timeout_jiffies = msecs_to_jiffies(1000); + + if (!wait_for_completion_timeout(&ipa->completion, timeout_jiffies)) + dev_err(&ipa->pdev->dev, "%s time out\n", __func__); } void ipa_cmd_pipeline_clear(struct ipa *ipa) -- 2.33.0
| |