Messages in this thread | | | From | <> | Subject | RE: [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support | Date | Fri, 17 Sep 2021 15:56:54 +0530 |
| |
> -----Original Message----- > From: Stephen Boyd <swboyd@chromium.org> > Sent: Friday, September 17, 2021 11:56 AM > To: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org; > bjorn.andersson@linaro.org; mathieu.poirier@linaro.org; ohad@wizery.com; > p.zabel@pengutronix.de; robh+dt@kernel.org > Cc: linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; sibis@codeaurora.org; mpubbise@codeaurora.org; > kuabhs@chromium.org > Subject: Re: [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280 > WPSS support > > Quoting Rakesh Pillai (2021-09-16 09:55:52) > > @@ -78,6 +84,10 @@ properties: > > Phandle reference to a syscon representing TCSR followed by the > > three offsets within syscon for q6, modem and nc halt registers. > > > > + qcom,qmp: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: Reference to the AOSS side-channel message RAM. > > + > > qcom,smem-states: > > $ref: /schemas/types.yaml#/definitions/phandle-array > > description: States used by the AP to signal the Hexagon core @@ > > -117,6 +127,33 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,sc7280-wpss-pil > > + then: > > Honestly I find this if/else to be a huge tangle. Why not split the binding so > that each compatible is a different file? Then it is easier to read and see what > properties to set.
Hi Stephen, I will create a separate dt-bindings yaml file for sc7280-wpss-pil, which will avoid all such if-else conditions.
> > > + properties: > > + interrupts-extended: > > + maxItems: 6 > > + items: > > + - description: Watchdog interrupt > > + - description: Fatal interrupt > > + - description: Ready interrupt
| |