lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 140/306] selftests: firmware: Fix ignored return val of asprintf() warn
    Date
    From: Shuah Khan <skhan@linuxfoundation.org>

    [ Upstream commit fe968ca2cac91888310b143a483123c84906e3fc ]

    Fix the following ingonred return val of asprintf() warn during
    build:

    cc -Wall -O2 fw_namespace.c -o ../tools/testing/selftests/firmware/fw_namespace
    fw_namespace.c: In function ‘main’:
    fw_namespace.c:132:2: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    132 | asprintf(&fw_path, "/lib/firmware/%s", fw_name);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20210708031827.51293-1-skhan@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/firmware/fw_namespace.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/firmware/fw_namespace.c b/tools/testing/selftests/firmware/fw_namespace.c
    index 5ebc1aec7923..817b2f1e8ee6 100644
    --- a/tools/testing/selftests/firmware/fw_namespace.c
    +++ b/tools/testing/selftests/firmware/fw_namespace.c
    @@ -129,7 +129,8 @@ int main(int argc, char **argv)
    die("mounting tmpfs to /lib/firmware failed\n");

    sys_path = argv[1];
    - asprintf(&fw_path, "/lib/firmware/%s", fw_name);
    + if (asprintf(&fw_path, "/lib/firmware/%s", fw_name) < 0)
    + die("error: failed to build full fw_path\n");

    setup_fw(fw_path);

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-16 18:24    [W:3.344 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site