lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 054/306] HID: input: do not report stylus battery state as "full"
    Date
    From: Dmitry Torokhov <dmitry.torokhov@gmail.com>

    [ Upstream commit f4abaa9eebde334045ed6ac4e564d050f1df3013 ]

    The power supply states of discharging, charging, full, etc, represent
    state of charging, not the capacity level of the battery (for which
    we have a separate property). Current HID usage tables to not allow
    for expressing charging state of the batteries found in generic
    styli, so we should simply assume that the battery is discharging
    even if current capacity is at 100% when battery strength reporting
    is done via HID interface. In fact, we were doing just that before
    commit 581c4484769e.

    This change helps UIs to not mis-represent fully charged batteries in
    styli as being charging/topping-off.

    Fixes: 581c4484769e ("HID: input: map digitizer battery usage")
    Reported-by: Kenneth Albanowski <kenalba@google.com>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/hid-input.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
    index d1ab2dccf6fd..580d378342c4 100644
    --- a/drivers/hid/hid-input.c
    +++ b/drivers/hid/hid-input.c
    @@ -415,8 +415,6 @@ static int hidinput_get_battery_property(struct power_supply *psy,

    if (dev->battery_status == HID_BATTERY_UNKNOWN)
    val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
    - else if (dev->battery_capacity == 100)
    - val->intval = POWER_SUPPLY_STATUS_FULL;
    else
    val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
    break;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-16 18:09    [W:4.059 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site