lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 016/306] selftests/ftrace: Fix requirement check of README file
    Date
    From: Steven Rostedt (VMware) <rostedt@goodmis.org>

    commit 210f9df02611cbe641ced3239122b270fd907d86 upstream.

    The selftest for ftrace checks some features by checking if the README has
    text that states the feature is supported by that kernel. Unfortunately,
    this check gives false positives because it many not be checked if there's
    spaces in the string to check. This is due to the compare between the
    required variable with the ":README" string stripped, because neither has
    quotes around them.

    Link: https://lkml.kernel.org/r/20210820204742.087177341@goodmis.org

    Cc: "Tzvetomir Stoyanov" <tz.stoyanov@gmail.com>
    Cc: Tom Zanussi <zanussi@kernel.org>
    Cc: Shuah Khan <shuah@kernel.org>
    Cc: Shuah Khan <skhan@linuxfoundation.org>
    Cc: linux-kselftest@vger.kernel.org
    Cc: stable@vger.kernel.org
    Fixes: 1b8eec510ba64 ("selftests/ftrace: Support ":README" suffix for requires")
    Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    tools/testing/selftests/ftrace/test.d/functions | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/tools/testing/selftests/ftrace/test.d/functions
    +++ b/tools/testing/selftests/ftrace/test.d/functions
    @@ -115,7 +115,7 @@ check_requires() { # Check required file
    echo "Required tracer $t is not configured."
    exit_unsupported
    fi
    - elif [ $r != $i ]; then
    + elif [ "$r" != "$i" ]; then
    if ! grep -Fq "$r" README ; then
    echo "Required feature pattern \"$r\" is not in README."
    exit_unsupported

    \
     
     \ /
      Last update: 2021-09-16 18:04    [W:4.048 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site