lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] Input: sc27xx-vibra - Make use of the helper function dev_err_probe()
Date
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/input/misc/sc27xx-vibra.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/input/misc/sc27xx-vibra.c b/drivers/input/misc/sc27xx-vibra.c
index 1478017f0968..7cf0a1354320 100644
--- a/drivers/input/misc/sc27xx-vibra.c
+++ b/drivers/input/misc/sc27xx-vibra.c
@@ -135,10 +135,9 @@ static int sc27xx_vibra_probe(struct platform_device *pdev)
}

error = device_property_read_u32(&pdev->dev, "reg", &info->base);
- if (error) {
- dev_err(&pdev->dev, "failed to get vibrator base address.\n");
- return error;
- }
+ if (error)
+ return dev_err_probe(&pdev->dev, error,
+ "failed to get vibrator base address.\n");

info->input_dev = devm_input_allocate_device(&pdev->dev);
if (!info->input_dev) {
--
2.25.1
\
 
 \ /
  Last update: 2021-09-16 17:34    [W:0.060 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site