lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] Input: nspire-keypad - Make use of the helper function dev_err_probe()
Date
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/input/keyboard/nspire-keypad.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/input/keyboard/nspire-keypad.c b/drivers/input/keyboard/nspire-keypad.c
index e9fa1423f136..06c8f7c16ec7 100644
--- a/drivers/input/keyboard/nspire-keypad.c
+++ b/drivers/input/keyboard/nspire-keypad.c
@@ -181,10 +181,9 @@ static int nspire_keypad_probe(struct platform_device *pdev)
keypad->active_low = of_property_read_bool(of_node, "active-low");

keypad->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(keypad->clk)) {
- dev_err(&pdev->dev, "unable to get clock\n");
- return PTR_ERR(keypad->clk);
- }
+ if (IS_ERR(keypad->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(keypad->clk),
+ "unable to get clock\n");

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
keypad->reg_base = devm_ioremap_resource(&pdev->dev, res);
--
2.25.1
\
 
 \ /
  Last update: 2021-09-16 17:34    [W:0.033 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site