Messages in this thread | | | From | Vladimir Oltean <> | Subject | Re: [PATCH v1 net] net: mscc: ocelot: remove buggy and useless write to ANA_PFC_PFC_CFG | Date | Thu, 16 Sep 2021 14:56:38 +0000 |
| |
On Thu, Sep 16, 2021 at 07:52:39AM -0700, Jakub Kicinski wrote: > On Thu, 16 Sep 2021 11:49:18 +0000 Vladimir Oltean wrote: > > git format-patch -2 --cover-letter > > Nice instructions, let me toss this version from pw. > > FWIW the patchwork checks don't complain about 2-patch series without > a cover letter [1]. Having cover letters is a good rule of thumb but > I thought I'd mention that 'cause unlikely anyone would realize otherwise. > > [1] https://github.com/kuba-moo/nipa/blob/master/tests/series/cover_letter/test.py
In my certainly limited experience I have found out that forcing yourself to write a change log and a cover letter makes you think more, which is sadly sometimes needed.
| |