lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v5] bus: mhi: core: Add support for processing priority of event ring
    Date
    Hi Bhaumik,

    Bhaumik Bhatt <bbhatt@codeaurora.org> writes:

    > On 2021-07-16 11:22 AM, Bhaumik Bhatt wrote:
    >> Hi Mani,
    >>
    >> On 2021-07-16 04:49 AM, Manivannan Sadhasivam wrote:
    >>> On Fri, Jun 25, 2021 at 10:22:08AM -0700, Bhaumik Bhatt wrote:
    >>>> From: Hemant Kumar <hemantk@codeaurora.org>
    >>>>
    >>>> Event ring priorities are currently set to 1 and are unused.
    >>>> Default processing priority for event rings is set to regular
    >>>> tasklet. Controllers can choose to use high priority tasklet
    >>>> scheduling for certain event rings critical for processing such
    >>>> as ones transporting control information if they wish to avoid
    >>>> system scheduling delays for those packets. In order to support
    >>>> these use cases, allow controllers to set event ring priority to
    >>>> high.
    >>>>
    >>>
    >>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    >>>
    >>> Just curious, what are the event rings you are going to make as high
    >>> priority? If you are going to do that for existing controllers, please
    >>> submit a patch now itself.
    >>>
    >>> Thanks,
    >>> Mani
    >>>
    >> Idea for this patch came from 914b72a6948b ("bus: mhi: Wait for M2
    >> state during system resume").
    >>
    >> If WLAN ath11k controller driver wants to avoid the scenario
    >> mentioned in
    >> the above patch, it will help them to have a high priority for their
    >> dedicated
    >> control events ring.
    >>
    >> I would defer to Kalle and others in ath11k, whether or not they are
    >> OK to take that route.
    >> as an update to priority will just help return from resume faster.
    >> It will also depend on system load/reproducibility rate of the
    >> scenario.
    >>
    >> I can provide a patch for them to review/test since I do not have the
    >> setup for it.
    >>
    > Would you like to try this patch out? It basically increases the
    > priority
    > at which the control events for M0/M1/M3 state changes are handled.
    >
    > Let me know if you have any questions.

    At the moment I'm seriously lagging with patches so I don't really have
    any free time. Can some other ath11k developer help here?

    --
    https://patchwork.kernel.org/project/linux-wireless/list/

    https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

    \
     
     \ /
      Last update: 2021-09-16 07:29    [W:3.398 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site