lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Input: lpc32xx-keys - Make use of the helper function dev_err_probe()
    From
    Date
    Hi Cai,

    On 9/16/21 6:33 PM, Cai Huoqing wrote:
    > When possible use dev_err_probe help to properly deal with the
    > PROBE_DEFER error, the benefit is that DEFER issue will be logged
    > in the devices_deferred debugfs file.
    > Using dev_err_probe() can reduce code size, and the error value
    > gets printed.
    >
    > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
    > ---
    > drivers/input/keyboard/lpc32xx-keys.c | 7 +++----
    > 1 file changed, 3 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/input/keyboard/lpc32xx-keys.c b/drivers/input/keyboard/lpc32xx-keys.c
    > index 943aeeb0de79..12bdf68b8fe7 100644
    > --- a/drivers/input/keyboard/lpc32xx-keys.c
    > +++ b/drivers/input/keyboard/lpc32xx-keys.c
    > @@ -227,10 +227,9 @@ static int lpc32xx_kscan_probe(struct platform_device *pdev)
    >
    > /* Get the key scanner clock */
    > kscandat->clk = devm_clk_get(&pdev->dev, NULL);
    > - if (IS_ERR(kscandat->clk)) {
    > - dev_err(&pdev->dev, "failed to get clock\n");
    > - return PTR_ERR(kscandat->clk);
    > - }
    > + if (IS_ERR(kscandat->clk))
    > + return dev_err_probe(&pdev->dev, PTR_ERR(kscandat->clk),
    > + "failed to get clock\n");
    >
    > /* Configure the key scanner */
    > error = clk_prepare_enable(kscandat->clk);
    >

    thank you for the change!

    Acked-by: Vladimir Zapolskiy <vz@mleia.com>

    --
    Best wishes,
    Vladimir

    \
     
     \ /
      Last update: 2021-09-16 22:08    [W:3.620 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site