Messages in this thread | | | Subject | Re: [PATCH 01/14] selftests/x86/sgx: Fix a benign linker warning | From | Reinette Chatre <> | Date | Thu, 16 Sep 2021 10:31:46 -0700 |
| |
Hi Jarkko,
On 9/16/2021 7:39 AM, Jarkko Sakkinen wrote: > On Thu, 2021-09-16 at 17:38 +0300, Jarkko Sakkinen wrote: >> On Wed, 2021-09-15 at 13:30 -0700, Reinette Chatre wrote: >>> From: Sean Christopherson <sean.j.christopherson@intel.com> >>> >>> Pass a build id of "none" to the linker to suppress a warning about the >>> build id being ignored: >>> >>> /usr/bin/ld: warning: .note.gnu.build-id section discarded, --build-id >>> ignored. >>> >>> Link: https://lore.kernel.org/linux-sgx/20191017030340.18301-2-sean.j.christopherson@intel.com/ >>> Co-developed-by: Cedric Xing <cedric.xing@intel.com> >>> Signed-off-by: Cedric Xing <cedric.xing@intel.com> >>> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> >>> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> >> >> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> > > ... but I don't get the use "co-developed-by" tag in this. I mean > it's one line change. Maybe it should be "suggested-by"?
I checked in with Cedric and he is ok with changing it to "Suggested-by".
At this time I have the following signatures planned for this patch in the next version:
Suggested-by: Cedric Xing <cedric.xing@intel.com> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Acked-by: Dave Hansen <dave.hansen@linux.intel.com> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
| |