lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 390/432] net: hns3: clean up a type mismatch warning
    Date
    From: Guojia Liao <liaoguojia@huawei.com>

    [ Upstream commit e79c0e324b011b0288cd411a5b53870a7730f163 ]

    abs() returns signed long, which could not convert the type
    as unsigned, and it may cause a mismatch type warning from
    static tools. To fix it, this patch uses an variable to save
    the abs()'s result and does a explicit conversion.

    Signed-off-by: Guojia Liao <liaoguojia@huawei.com>
    Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
    index c0a478ae9583..0dbed35645ed 100644
    --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
    @@ -10,7 +10,14 @@

    static u16 hclge_errno_to_resp(int errno)
    {
    - return abs(errno);
    + int resp = abs(errno);
    +
    + /* The status for pf to vf msg cmd is u16, constrainted by HW.
    + * We need to keep the same type with it.
    + * The intput errno is the stander error code, it's safely to
    + * use a u16 to store the abs(errno).
    + */
    + return (u16)resp;
    }

    /* hclge_gen_resp_to_vf: used to generate a synchronous response to VF when PF
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-16 19:48    [W:4.025 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site