lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 096/432] RDMA/hns: Dont overwrite supplied QP attributes
    Date
    From: Leon Romanovsky <leonro@nvidia.com>

    [ Upstream commit e66e49592b690d6abd537cc207b07a3db2f413d0 ]

    QP attributes that were supplied by IB/core already have all parameters
    set when they are passed to the driver. The drivers are not supposed to
    change anything in struct ib_qp_init_attr.

    Fixes: 66d86e529dd5 ("RDMA/hns: Add UD support for HIP09")
    Link: https://lore.kernel.org/r/5987138875e8ade9aa339d4db6e1bd9694ed4591.1627040189.git.leonro@nvidia.com
    Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/hns/hns_roce_qp.c | 8 +-------
    1 file changed, 1 insertion(+), 7 deletions(-)

    diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c
    index b101b7e578f2..c3e2fee16c0e 100644
    --- a/drivers/infiniband/hw/hns/hns_roce_qp.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
    @@ -1171,14 +1171,8 @@ struct ib_qp *hns_roce_create_qp(struct ib_pd *pd,
    if (!hr_qp)
    return ERR_PTR(-ENOMEM);

    - if (init_attr->qp_type == IB_QPT_XRC_INI)
    - init_attr->recv_cq = NULL;
    -
    - if (init_attr->qp_type == IB_QPT_XRC_TGT) {
    + if (init_attr->qp_type == IB_QPT_XRC_TGT)
    hr_qp->xrcdn = to_hr_xrcd(init_attr->xrcd)->xrcdn;
    - init_attr->recv_cq = NULL;
    - init_attr->send_cq = NULL;
    - }

    if (init_attr->qp_type == IB_QPT_GSI) {
    hr_qp->port = init_attr->port_num - 1;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-16 19:25    [W:4.592 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site