lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 5/8] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero
From
Date


On 2021/9/16 14:16, Christoph Hellwig wrote:
> On Wed, Sep 15, 2021 at 06:44:58PM +0800, Shiyang Ruan wrote:
>> + rc = dax_direct_access(iomap->dax_dev, pgoff, 1, &kaddr, NULL);
>> + if (rc < 0)
>> + goto out;
>> + memset(kaddr + offset, 0, size);
>> + if (srcmap->addr != IOMAP_HOLE && srcmap->addr != iomap->addr) {
>
> Should we also check that ->dax_dev for iomap and srcmap are different
> first to deal with case of file system with multiple devices?

I have not thought of this case. Isn't it possible to CoW between
different devices?


--
Thanks,
Ruan

>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>


\
 
 \ /
  Last update: 2021-09-16 10:50    [W:0.049 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site