lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 186/380] media: atomisp: pci: fix error return code in atomisp_pci_probe()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit d14e272958bdfdc40dcafb827d24ba6fdafa9d52 ]

    If init_atomisp_wdts() fails, atomisp_pci_probe() need return
    error code.

    Link: https://lore.kernel.org/linux-media/20210617072329.1233662-1-yangyingliang@huawei.com
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
    index 02f774ed80c8..fa1bd99cd6f1 100644
    --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
    +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
    @@ -1763,7 +1763,8 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
    if (err < 0)
    goto register_entities_fail;
    /* init atomisp wdts */
    - if (init_atomisp_wdts(isp) != 0)
    + err = init_atomisp_wdts(isp);
    + if (err != 0)
    goto wdt_work_queue_fail;

    /* save the iunit context only once after all the values are init'ed. */
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-16 19:07    [W:4.265 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site