lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 189/380] drm/amdgpu: Fix a printing message
    Date
    From: Oak Zeng <Oak.Zeng@amd.com>

    [ Upstream commit 95f71f12aa45d65b7f2ccab95569795edffd379a ]

    The printing message "PSP loading VCN firmware" is mis-leading because
    people might think driver is loading VCN firmware. Actually when this
    message is printed, driver is just preparing some VCN ucode, not loading
    VCN firmware yet. The actual VCN firmware loading will be in the PSP block
    hw_init. Fix the printing message

    Signed-off-by: Oak Zeng <Oak.Zeng@amd.com>
    Reviewed-by: Christian Konig <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 2 +-
    drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +-
    drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 +-
    drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
    4 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
    index 27b1ced145d2..14ae2bfad59d 100644
    --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
    +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
    @@ -119,7 +119,7 @@ static int vcn_v1_0_sw_init(void *handle)
    adev->firmware.ucode[AMDGPU_UCODE_ID_VCN].fw = adev->vcn.fw;
    adev->firmware.fw_size +=
    ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE);
    - DRM_INFO("PSP loading VCN firmware\n");
    + dev_info(adev->dev, "Will use PSP to load VCN firmware\n");
    }

    r = amdgpu_vcn_resume(adev);
    diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
    index 8af567c546db..f4686e918e0d 100644
    --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
    +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
    @@ -122,7 +122,7 @@ static int vcn_v2_0_sw_init(void *handle)
    adev->firmware.ucode[AMDGPU_UCODE_ID_VCN].fw = adev->vcn.fw;
    adev->firmware.fw_size +=
    ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE);
    - DRM_INFO("PSP loading VCN firmware\n");
    + dev_info(adev->dev, "Will use PSP to load VCN firmware\n");
    }

    r = amdgpu_vcn_resume(adev);
    diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
    index 888b17d84691..e0c0c3734432 100644
    --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
    +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
    @@ -152,7 +152,7 @@ static int vcn_v2_5_sw_init(void *handle)
    adev->firmware.fw_size +=
    ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE);
    }
    - DRM_INFO("PSP loading VCN firmware\n");
    + dev_info(adev->dev, "Will use PSP to load VCN firmware\n");
    }

    r = amdgpu_vcn_resume(adev);
    diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
    index 3b23de996db2..c2c5c4af51d2 100644
    --- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
    +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
    @@ -152,7 +152,7 @@ static int vcn_v3_0_sw_init(void *handle)
    adev->firmware.fw_size +=
    ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE);
    }
    - DRM_INFO("PSP loading VCN firmware\n");
    + dev_info(adev->dev, "Will use PSP to load VCN firmware\n");
    }

    r = amdgpu_vcn_resume(adev);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-16 18:50    [W:4.069 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site