Messages in this thread Patch in this message | | | From | Cai Huoqing <> | Subject | [PATCH] net: cadence: macb: Make use of the helper function dev_err_probe() | Date | Wed, 15 Sep 2021 22:58:04 +0800 |
| |
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. And using dev_err_probe() can reduce code size, and simplify the code.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/net/ethernet/cadence/macb_pci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c index 8b7b59908a1a..d09c570a15ae 100644 --- a/drivers/net/ethernet/cadence/macb_pci.c +++ b/drivers/net/ethernet/cadence/macb_pci.c @@ -35,10 +35,8 @@ static int macb_probe(struct pci_dev *pdev, const struct pci_device_id *id) /* enable pci device */ err = pcim_enable_device(pdev); - if (err < 0) { - dev_err(&pdev->dev, "Enabling PCI device has failed: %d", err); - return err; - } + if (err < 0) + return dev_err_probe(&pdev->dev, err, "Enabling PCI device has failed\n"); pci_set_master(pdev); -- 2.25.1
| |